Problem with OnPlayerKill

[Runny]

Hello!

As I've came back to Soldat, I've came back to scripting. I'm writing TTW-alike-mod. There are some professions, which you can change by using cmds. If player is alive, his profession will change as soon as he will die. I use OnPlayerKill event, to check wheter player was killed and wanted to change his profession - if he did, Program calls ChangeProfession function. It works in two ways - if player is dead it change his profession immediately, if he's alive it sends a variable, which is checked when OnPlayerEvent is called. I check if player is alive with GetPlayerStat(ID, 'alive'). And there's a problem. Player is actually alive when the OnPlayerKill event is called. Look at this code:

Code: [Select]

procedure OnPlayerKill(Killer, Victim: byte;Weapon: string);
begin
if GetPlayerStat(Victim,'alive') then Writeln('hehe');
end;it prints 'hehe'. Is there a way, without using AppOnIdle, to solve my problem?

Hope you will understand me, I'm pretty tired

Merry Xmas

[Hacktank]

Code: [Select]

procedure OnPlayerKill(Killer, Victim: byte;Weapon: string);
begin
Writeln('hehe');
end;

[iDante]

Victim is dead. GetPlayerStat is just behind when OnPlayerKill is called.
There is no need to check whether he's alive or not. He's dead.

[DorkeyDear]

Just a note: I had times which Victim is alive, and victim is dead when OnPlayerKill is called (had something to due with explosions) so it may become of use if you figure out specifically when its true or false.

[Hacktank]

Just a note: I had times which Victim is alive, and victim is dead when OnPlayerKill is called (had something to due with explosions) so it may become of use if you figure out specifically when its true or false.

Very interesting, this may solve my problem with M79/LAW.

[Gizd]

Haha yes, that's an interesting thing. Found that while making Medic script(medics healed themselves after death because when player dies OnWeaponChange is called, the result was that every kill appeared as selfkill).
Use if GetPlayerStat(ID,'Health') > 0.

[Runny]

Hm, I didn't describe my problem clear. Maybe I will just put a sketch-code instead:

Code: [Select]

procedure ChangeProfession(ID,option:byte);
begin

if GetPlayerStat(ID, 'alive') = false then
           begin
           Players[ID].profession := option;
           WriteConsole(ID,'Your profession has been changed!',$FF001122);
           end
else
           begin
           Players[ID].changeafterdead := true;
           Players[ID].changeto := option;
           WriteConsole(ID,'Your profession will be changed at the next respawn',$FF001122);
end;
end;

procedure OnPlayerKill(Killer, Victim: byte;Weapon: string);
begin
if Players[Victim].changeafterdead = true then begin
ChangeProfession(ID,Players[ID].changeto);
Players[Victim].changeafterdead := false;
Players[Victim].changeto := -1;
end;
end;

It's very shortened version of the code, but it shows my problem. Once player has joined the server, it keeps showing 'Your profession will be changed at the next respawn' msg, without changing the profession. You can change your profession successfully only when you are dead. OnPlayerKill is called properly, but then in ChangeProfession procedure, player's alive stat is always true...

[Gizd]

Use if GetPlayerStat(ID,'Health') > 0.

...instead of GetPlayerStat(ID,'Alive').

[Runny]

Hmm, that's nice idea. Thanks

@edit:
It works. Thank you very much!

[DorkeyDear]

Just a note: I had times which Victim is alive, and victim is dead when OnPlayerKill is called (had something to due with explosions) so it may become of use if you figure out specifically when its true or false.

Very interesting, this may solve my problem with M79/LAW.

Hm, I may have been thinking OnPlayerDamage, but it still might want to be looked into.. May also want to look into victim's health, it tends to be -400 OnPlayerDamage (but not always) for explosion (if I recall correctly).

[y0uRd34th]

You recalled it correctly, it was so interesting that I just go an tested it out with tons of bots
When the damage is negative its mostly -400 but not always.
Here a short part of the log i made with:

...
health: -139 Damage: 80
health: -400 Damage: 75
health: -219 Damage: 80
health: -400 Damage: 75
health: -400 Damage: 16566
health: -400 Damage: 82
health: -400 Damage: 292
health: -400 Damage: 82
health: -400 Damage: 139
health: -140 Damage: 80
health: -220 Damage: 48
health: -400 Damage: 82
health: -400 Damage: 18828
health: 150 Damage: 600
health: -400 Damage: 17908
health: 150 Damage: 48
health: -400 Damage: 18
health: -389 Damage: 23
health: -400 Damage: 46
health: -400 Damage: 72
health: 150 Damage: 50
health: 150 Damage: 55
health: -400 Damage: 20168
health: 150 Damage: 109
health: 150 Damage: 126
...

[DorkeyDear]

@y0uRd34th: I think when its a direct explosion kill (M79 right in the face ) its -400, but if its an indirect kill (such as explosion hitting a poly near a player) it is smaller.

[y0uRd34th]

Yes, but this wills till not solve scripters problem with the M79 explosion, but atleast this is an interesting tip.