Account System - corrupted files

[ShadowDancer]

Hello, I'm working on my server script and I find one hard problem. I'm saving player account in .ini file, but when i'm trying to read it sometimes fail. What can be reasion of this?

I'm doing it like this:

Code: [Select]

procedure Save(ID)
begin
     WriteLnFile(Name+'.ini', data);
end

OnLeaveGame(id, kicked)
begin
     Save(ID);
end

OnPlayerCommand(ID, Text)
begin
    if GetPiece(Text, ' ', 1) = '/logout' then Save(ID);
end


[Stuffy]

is that your whole script?

or just an example?

[mich1103]

Example XD

[ShadowDancer]

is that your whole script?

lol Pseudocode. I'm calling function save in onplayerleave event. Function save contains WriteFIle, that creates file, and next filling it with WriteFileLn

Here is part of whole script: http://nopaste.gamedev.pl/?id=6723

[DorkeyDear]

@ShadowDancer: A person's name can contain stuff that a filename cannot (a '?' for example, I think...).
You must change the person's name into something that can be guaranteed the ability to save it.

Maybe a function EncodeString(const Str: string): string; which converts each character into a 2-character hex value (exactly double in length; but you must prefix with 0 for numbers between 0 and F (00, 01, 02, ...0E, 0F, 1A, ..., FF)

I created a thing for it (don't have access to it right now) but still, if you try to figure it out, the more experience for you ; just say if you want me to post it.

EDIT: Oh.. i took a look at the pseudocode and realized you already have a ProcessName thing going on... but im not sure why you do map.ProcessName(name) :/ (just know that if you try to crossfunc 'foo.bar', it'll try to call 'bar' inside of the script named 'foo')

[mich1103]

I think that the problem we have is due onplayerleave because when i go modify
the lvl of skills and i save it (in the folder of the Acc)! I go ingame i have the skills ive modified but when i leave my skills recome with -1 ... so i think is due to the INI writting

[ShadowDancer]

@ShadowDancer: A person's name can contain stuff that a filename cannot (a '?' for example, I think...).
You must change the person's name into something that can be guaranteed the ability to save it.

Maybe a function EncodeString(const Str: string): string; which converts each character into a 2-character hex value (exactly double in length; but you must prefix with 0 for numbers between 0 and F (00, 01, 02, ...0E, 0F, 1A, ..., FF)

Function ProcessName converts all '<', '?' , '|' etc. in char (250), char (251) etc.
File exists, everything works in most cases, but sometimes just there's reading file error, and ReadIni pleaces invalid value.

[Gizd]

Do you use built-in ReadINI() ?

[ShadowDancer]

yes

Here is nearby full code: http://nopaste.gamedev.pl/?id=6723
It works, but sometimes crashes. Maybe it's due to server restarting with ctrl+c?

[mich1103]

Hmmmm the server has crashed again for another reason !!!

[Swompie]

It's a pretty old script by Gizd, the script can crash easily when you declared alot of special bots aswell having alot of bots in the server. Make such a script yourself is way better. (It has lots of loops /:)

[ShadowDancer]

I found in another topic something about ini files, maybe it can be because of storing data inside ini files?

[dnmr]

I found in another topic something about ini files, maybe it can be because of storing data inside ini files?

i've used them alot before, and haven't had too many problems. How often does it break?

[ShadowDancer]

I dont know, i'm just playing and sometimes when checking stats i see -1 ;/ I will check it.

[Stuffy]

lol Pseudocode. I'm calling function save in onplayerleave event. Function save contains WriteFIle, that creates file, and next filling it with WriteFileLn

Better save than sorry

[dnmr]

welll... Looks like you do a lot of readinis when you can do one readfile and then parse it. Could anyone who used crossfunc a lot comment on its reliability?

[Gizd]

Just make your own INI-reading procedure \o/

[Swompie]

Or simply don't use it and make your own saving system and seperate data with a space or another symbols.. Most people use that since own INI-Reading/Writing w/e functions aren't the best for your server due to much loops D: