Out of Range in OnAdminMessage

[Stuffy]

Why is this codepart giving me a Out of Range error?

Code: [Select]

procedure OnAdminMessage(IP, Msg: string);

var
i, TcpAdmins : integer;
AdminName : array of string;

begin
  if (GetPiece(Msg,' ',0) = '[ª]') then begin
    TcpAdmins := 1;
      if TcpAdmins > 0 then begin
        for i := 0 to TcpAdmins -1 do
          AdminName[i] := GetPiece(GetPiece(Msg,'[ª] ',1),':',0);
            WriteLn(AdminName[i]);
      end else WriteLn('Error');
  end;
end;
I have no idea whats wrong with it

[Swompie]

The array length of AdminName is 0, you need to set it with SetArrayLength() first.

[Stuffy]

ahh, yes, thank you very much

[DarkCrusade]

You should use global variables for this so the admin's name is not lost after the procedure ends. However, if you take a closer look at your script you'll notice that 'TcpAdmins' will always be 1. The worst thing is that you don't increase the length of the array whilst idling through the whole list writing the admin's name everywhere and spamming the console with unnecessary messages.

Code: [Select]

var
  AdminName:Array of String;
  TcpAdmins:Byte;

Function AdminNames(Name:String):Boolean;
var
  i:Byte;
begin
  for i := 0 to TcpAdmins-1 do
    if AdminName[i] = Name then begin#
      Result := false;
      break;
    end;
end;

Procedure OnAdminMessage(IP, Msg: string); 
begin
  if (GetPiece(Msg,' ',0) = '[ª]') AND (AdminNames(GetPiece(Msg,' ',0))) then begin
    TcpAdmins := TcpAdmins + 1;
    SetArrayLength(AdminName,TcpAdmins);
    AdminName[TcpAdmins-1] := GetPiece(GetPiece(Msg,'[ª] ',1),':',0);
    WriteLn(AdminName[i]);
  end;
end;
This should be working..

[Stuffy]

uhm, this was just a example codepart, tcp admins and AdminName are global vars in the original script

I have got another problem, somehow

Code: [Select]

if (GetPiece(Msg,' ',0) = '[ª]') is triggered on my local test server, but not on my online server

[dnmr]

it probably doesn't like that weird ª character, try using something else

[Stuffy]

I cant. ª is the only character that isnt changing.

[frosty]

if its using a value that isnt going to change then use a const, give it a reasonable name, etc

example, using your code:

Code: (pascal) [Select]

const
yourvar = '0'; //or whatever, but since in your code this is used as a string i have given it a string value

var
//your vars here

Function AdminNames(Name:String):Boolean;
var
  i:Byte;
begin
  for i := 0 to TcpAdmins-1 do
    if AdminName[i] = Name then begin#
      Result := false;
      break;
    end;
end;

Procedure OnAdminMessage(IP, Msg: string); 
begin
  if (GetPiece(Msg,' ',0) = '[yourvar]') AND (AdminNames(GetPiece(Msg,' ',0))) then begin
    TcpAdmins := TcpAdmins + 1;
    SetArrayLength(AdminName,TcpAdmins);
    AdminName[TcpAdmins-1] := GetPiece(GetPiece(Msg,'[yourvar] ',1),':',0);
    WriteLn(AdminName[i]);
  end;
end;
hope this helps

[Stuffy]

nah this wont work, its a ubuntu-based problem

[tk]

It's not a ubuntu based problem
I don't remember exactly what char clientlist uses. 170?
If so try '[' + #170 + ']' ...