How to write?

[rOy]

hello i need help with one script

I Have a problem with this

Code: [Select]

procedure OnJoinGame(ID, Team: byte);
var
    i:byte;
begin
if not FileExists('scripts/asd' +CurrentMap+ '.log') then WriteFile('scripts/asd' +CurrentMap+ '.log');
if not FileExists('scripts/asd' +lowercase(player+) '.log') then WriteFile('scripts/asd' +lowercase(player)+ '.log');
end;
Why doesn't work?

To write .log files

Script is a separate

Files free
Files.log only

Thanks for the advice

[DorkeyDear]

The event OnJointGame specifies the id of the player joining the game. It appears you are trying to write to a file containing the name of the player, however the variable player does not exist. You will need to get the name of the player with the id ID. In this code, I define such a variable and assign it to be the name of the player. Also, you have a misplaced the + character in the second if statement line in 'scripts/asd' +lowercase(player+) '.log'.

procedure OnJoinGame(ID, Team: byte);
var
    i:byte;
    player:string;
begin
player := GetPlayerStat(ID, 'name');
if not FileExists('scripts/asd' +CurrentMap+ '.log') then WriteFile('scripts/asd' +CurrentMap+ '.log', 'dummy text');
if not FileExists('scripts/asd' +lowercase(player)+ '.log') then WriteFile('scripts/asd' +lowercase(player)+ '.log', 'dummy text');
end;

I did not test this code.

[Tehbugerz0r]

Writefile has two parameters: function WriteFile(FileName, Data: string): boolean;
You could use WriteFile('scripts/asd' +CurrentMap+ '.log', ''); to write nothing(probably), but there's no real point in doing so.

[DorkeyDear]

Woops you are right Tehbugerz0r; I did not notice, rOy, you forgot the second argument/parameter to WriteFile. I edited my previous code to include some dummy text. It now should write 'dummy text' (without quotes) to both files.

[rOy]

The event OnJointGame specifies the id of the player joining the game. It appears you are trying to write to a file containing the name of the player, however the variable player does not exist. You will need to get the name of the player with the id ID. In this code, I define such a variable and assign it to be the name of the player. Also, you have a misplaced the + character in the second if statement line in 'scripts/asd' +lowercase(player+) '.log'.

procedure OnJoinGame(ID, Team: byte);
var
    i:byte;
    player:string;
begin
player := GetPlayerStat(ID, 'name');
if not FileExists('scripts/asd' +CurrentMap+ '.log') then WriteFile('scripts/asd' +CurrentMap+ '.log', 'dummy text');
if not FileExists('scripts/asd' +lowercase(player)+ '.log') then WriteFile('scripts/asd' +lowercase(player)+ '.log', 'dummy text');
end;

I did not test this code.

DorkeyDear nice release but I need only:
That form only free files.
Example: I've nick rOy and Current map is ctf_Ash
And I join the game (maybe without logs) Must create free logs (map and player Name)
I've a question may be example IDToName(i) ? + GetPlayerStat ?

I don't want to write to 'dummy.txt'

Thanks for help

[DorkeyDear]

Currently, it would NOT write to the file dummy.txt. The way it is now is it will try to write to two files (if they do not already exist): scripts/asdMapName.log and scripts/asdplayername.log (where the underlined stuff would be variable). The content of the file will be "dummy text" (without quotes). That can be easily changed in the script (look for the part that says 'dummy text' and change what is between the ' single quote marks ' ). If you want the files to be blank (no content), have no text there (simply ''; two consecutive single quote marks).

Regarding your question of IDToName vs GetPlayerStat, I do not know. I think IDToName is still implemented, but as far as I know, it is not preferred, and I always thought of it as depreciated. I could be wrong about this though, and am not completely certain.

[rOy]

Currently, it would NOT write to the file dummy.txt. The way it is now is it will try to write to two files (if they do not already exist): scripts/asdMapName.log and scripts/asdplayername.log (where the underlined stuff would be variable). The content of the file will be "dummy text" (without quotes). That can be easily changed in the script (look for the part that says 'dummy text' and change what is between the ' single quote marks ' ). If you want the files to be blank (no content), have no text there (simply ''; two consecutive single quote marks).

Regarding your question of IDToName vs GetPlayerStat, I do not know. I think IDToName is still implemented, but as far as I know, it is not preferred, and I always thought of it as depreciated. I could be wrong about this though, and am not completely certain.

Hey
I understand you.

I've a test
This

Code: [Select]

procedure OnJoinGame(ID, Team: byte);
var
    i:byte;
    player:string;
begin
player := GetPlayerStat(ID, 'name');
if not FileExists('scripts/asd' +CurrentMap+ '.log') then WriteFile('scripts/asd' +CurrentMap, '.log');
if not FileExists('scripts/asd' +lowercase(player)+ '.log') then WriteFile('scripts/asd' +lowercase(player)+ GetPlayerStat, '.log');
end;
where's the problem?
Log say:
asd -> [Error] (9:123): Invalid number of parameters

If have change (,)

Code: [Select]

procedure OnJoinGame(ID, Team: byte);
var
    i:byte;
    player:string;
begin
player := GetPlayerStat(ID, 'name');
if not FileExists('scripts/asd' +CurrentMap+ '.log') then WriteFile('scripts/asd' +CurrentMap '.log');
if not FileExists('scripts/asd' +lowercase(player)+ '.log') then WriteFile('scripts/asd' +lowercase(player)+ GetPlayerStat '.log');
end;
Log say:
asd -> [Error] (8:95): comma (',') expected
the script does't know where to write (logic)

But it is written that (on script CurrentMap and Player)
Why not writting?

Script name is: asd

[DorkeyDear]

I've a test
This

Code: [Select]

procedure OnJoinGame(ID, Team: byte);
var
    i:byte;
    player:string;
begin
player := GetPlayerStat(ID, 'name');
if not FileExists('scripts/asd' +CurrentMap+ '.log') then WriteFile('scripts/asd' +CurrentMap, '.log');
if not FileExists('scripts/asd' +lowercase(player)+ '.log') then WriteFile('scripts/asd' +lowercase(player)+ GetPlayerStat, '.log');
end;
where's the problem?
Log say:
asd -> [Error] (9:123): Invalid number of parameters

if not FileExists('scripts/asd' +lowercase(player)+ '.log') then WriteFile('scripts/asd' +lowercase(player)+ GetPlayerStat, '.log');

The issue is with your GetPlayerStat. If you wanted to put the player's name at that point there, have it be GetPlayerStat(ID, 'name') or player. Keep is mind GetPlayerStat is a function, similar to how WriteFile is a function, it takes 2 parameters/arguments. However, we already stored the name of the player in a variable called player, which I see you are using here lowercase(player) before the GetPlayerStat. We therefore do not need the GetPlayerStat part there at all.

You removing the comma from the code shows me you do not know the logic or structure of what is going on. I can't really teach this very easily.

Code: [Select]

procedure OnJoinGame(ID, Team: byte);
var
    i:byte;
    player:string;
begin
player := GetPlayerStat(ID, 'name');
if not FileExists('scripts/asd' +CurrentMap+ '.log') then WriteFile('scripts/asd' +CurrentMap, '.log');
if not FileExists('scripts/asd' +lowercase(player)+ '.log') then WriteFile('scripts/asd' +lowercase(player), '.log');
end;WriteFile is a function which takes two inputs. The first argument is for the filename of what file to write to, and the second is the contents of that file: WriteFile('filename.txt', 'content') will write the text content to the file filename.txt. The second argument of WriteFile, which is the file contents, will be the text content. In your problem, the first argument for WriteFile is dependent on other stuff; the player name is dynamic. The filename is going to be the result of this code: 'scripts/asd' +lowercase(player)+ '.log'. The second argument of WriteFile, which is the file contents, will be the text .log.

[Swompie]

Curt: You may filter out invalid filename characters to avoid problems, but would probably confuse him (and include a little bit of work i never liked)

r0y: Check this out if you haven't. It's worth it.