AlivePlayers

[DorkeyDear]

I'm having issues with getting the number of alive players... I'm trying not to use for loops.

Code: [Select]

var
  AlivePlayers,AfterJoinTeam,AfterKill,Old: byte;

procedure AppOnIdle(Ticks: integer);
var
  i: byte;
begin
  if AfterJoinTeam <> 0 then begin
    if GetPlayerStat(AfterJoinTeam,'Alive') = true then AlivePlayers := AlivePlayers + 1;
    AfterJoinTeam := 0;
  end;
  if AfterKill <> 0 then begin
    for i := 1 to NumPlayers do if Target[i] = AfterKill then begin
      Command('/setteam ' + InttoStr(i));
Command('/say ' + InttoStr(i) + ' respawned due to his killer, ' + InttoStr(AfterKill) + ', dieing.');
    end;
    AfterKill := 0;
  end;
  if Old <> AlivePlayers then begin
    Command('/say AlivePlayers = ' + InttoStr(AlivePlayers) + ' / ' + InttoStr(NumPlayers));
    Old := AlivePlayers;
  end;
end;

procedure OnJoinTeam(ID, Team: byte);
begin
  AfterJoinTeam := ID;
end;

procedure OnLeaveGame(ID, Team: byte; Kicked: boolean);
begin
  if GetPlayerStat(ID,'Alive') = true then AlivePlayers := AlivePlayers - 1;
end;

procedure OnPlayerKill(Killer, Victim: byte; Weapon: string);
var
  i: byte;
begin
  AlivePlayers := AlivePlayers - 1;
  AfterKill := Victim;
end;

procedure OnPlayerRespawn(ID: byte);
begin
  AlivePlayers := AlivePlayers + 1;
end;
It may have something to do with when the script does Command('setteam_ _') and that not calling OnPlayerRespawn, but whenever I do specific tests, it seems to do fine. Its really hard to find the cause with bots. AlivePlayers is always correct or too high, never too low.

(Deathmatch)

I also suggest having AlivePlayers or something as an implemented byte (but then to make it fair, you would need alpha, bravo, charlie, and delta alive players too, but whatever)

[urraka]

I think the script isn't very consistent the way you are doing it. AppOnIdle is supposed to get called each second, so if 2 players die at the same time only one would be counted i guess. Also OnLeaveGame isn't very effective, because sometimes players get diconnected without calling any event.
Why do you try to avoid for loops. Making a loop for 32 players won't cause any performance issue. I think you must use the for loop each time you want to count the players alive.

[mikembm]

GetPlayerStat has an alive option...

[urraka]

GetPlayerStat has an alive option...

He already knows.. did you take a look at the code? That option only informs if one player is alive or not.. not how many players are alive in the moment.

[Quantifier]

First, don't use NumPlayers as number of loop iterations, it will work reliably only until for the first time someone leaves the server. MaxPlayers is better, but still won't catch admins that joined on full server.
Second, you never define target here, or even assign value to it.
Third, afterkill holds the value of victim, then in apponidle you say it's a killer. I guess it has to do with missing code involving target array?

[Avarax]

Code: [Select]

function AlivePlayers: byte;
var i: byte;
begin
  result:=0;
  for i:=1 to 32 do
    If (GetPlayerStat(i,'Alive')=true) and (GetPlayerStat(i,'Active')=true) then
      result:=result + 1;
end;
it's that easy ;Q

[KeYDoN]

avarax: you should exclude specs

[Avarax]

afaik (GetPlayerStat(i,'Alive')=true) excludes them

[DorkeyDear]

Heh, I knew how to use the for loops. I just dislike using them when I don't need to. I guess I will be needing them, thanks.
(Now I am needing to know when each procedure is called so I can make the for loop be called after the player respawns or leaves or whatever..)
OnLeaveGame is not called when a player is disconnected? It should be...

[urraka]

You don't need to know that, just call Avarax function each time you need to know the value of AlivePlayers.

[DorkeyDear]

Yeah, or I could use it right before I need it. That works too. Smarter idea