Scripting failure experiences?

[Fryer]

I've decided to make a topic about it, because I decided to start my own server and do all the scripting for it, and apparently bugs appear sometimes...

Starting with something that just happened...

Yesterday I completed (or thought so) a script for my server, Haywire CTF, that makes it put players as spectator if there are already an amount of people playing. On my server I set this limit to 10. I had tested it on bots first and it was working quite well, so I did some small final adjustments before going live. BAD IDEA. I changed the server setting to add the server to the lobby; I joined; I waited... Slowly, people started joining.

At some point in time, the player count was being about 6-9, going up and down a bit, kinda like a cubed sine wave. I was ofc thinking about how the 11th player would react to the awesome script! ("omfg wtf stupid queue qq") Then the 10th player joined, and all havok occurred:

[...]
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
► +          .from russia with love has joined alpha team.
► +          .from russia with love has joined spectators.
[...]

Why? I had somehow in my haste to get the script done put ">=" instead of ">"!

So what was happening was that the 10th guy joined, and the script checked this:

Code: [Select]

if (AlphaPlayers + BravoPlayers >= PlayerLimit) [...]That was true, which sent him to the join queue (spectator). Then there was another code right after it which looked like this:

Code: [Select]

while (AlphaPlayers + BravoPlayers < PlayerLimit)[...]And that code sent him back to alpha team...

I guess someone must have had similar stuff happen, considering how little time I've spent on scripting. So yeah, let everyone know about those stupid mistakes, so people can laugh at you.

Related link

[ExHunter]

On Hide and Seek:

something like (out of my head):

Code: [Select]

procedure randomevent();
begin
  lastevent := currentevent;
  repeat
    currentevent := Random(10, 11);
  until(lastevent <> currentevent);
end;

Random(10,11); because I wanted to test a certain thing. Yea.. I like endless loops. Tested it on a full server (15 of 15 slots) - I took like 3 server restarts to finally get it

---

I could tell alot more, but I approve - every scripter knows that feel.. xD

Edit: Random(10,11); will always have 10 as result.

[DorkeyDear]

Random's 2nd parameter will never be reached. If you want integers form A (inclusive) to B (inclusive), you need to add 1 to B: Random(A, B+1).

[ExHunter]

Random's 2nd parameter will never be reached. If you want integers form A (inclusive) to B (inclusive), you need to add 1 to B: Random(A, B+1).

Yea, I know that. But the problem was, that I just wanted to test one certain event (so I made out of 1 a 10, so that it will always be 10), which made it crash. I thought this topic was supposed to post to show up our scripting fails.

[Fryer]

Something that was bothering me when making my team balancer and queue scripts was that at a certain point I just couldn't get it to work with bots anymore (since bots sometimes don't fire the joined team event). That would require me to ask people to join my server for script testing, which gets kinda annoying when they were not clear as to what they were doing and the script crashes.

I should probably try to fix that thing with bots anyways...

[Swompie]

Use a boolean variable and set it to false when the server starts or a player leaves the game.
Then check if it's false in OnPlayerRespawn and you know if a player has just joined.
It's already a known problem for a long time

[Fryer]

Use a boolean variable and set it to false when the server starts or a player leaves the game.
Then check if it's false in OnPlayerRespawn and you know if a player has just joined.
It's already a known problem for a long time

Ah, I didn't think about checking with OnPlayerRespawn; that's quite a nice quick fix for the way scripting works now, until I fix the bug. Got any cool ideas for how to check if the bot was added in spectators?

The boolean check thing I'm already using. (It's a bit more complex than boolean, but w/e.)

[Swompie]

You move bots to the spectator team by scripting (except the rare case when you already assign them to spec), get the point?