average ping on server (function), like arsse

[szmon]

Code: [Select]

function AveragePing(): integer;
var
i : integer;
ping: integer;
totalping: integer;
begin
  for i := 1 to 32 do begin
  totalping := totalping + GetPlayerStat(i,'Ping')
  i := i + 1
if i = 32 then
begin
ping := totalping / NumPlayers
end;
end;
Result := ping;
end;


[colby]

  nice script

[urraka]

It's a bit confusing i would write it this way:

Code: [Select]

function AveragePing(): integer;
var
    totalping, i: integer;
begin
    for i := 1 to 32 do
        totalping := totalping + GetPlayerStat(i,'Ping');

    Result := totalping / NumPlayers;
end;


[chrisgbk]

It's a bit confusing i would write it this way:

Code: [Select]

function AveragePing(): integer;
var
    totalping, i: integer;
begin
    for i := 1 to 32 do
        totalping := totalping + GetPlayerStat(i,'Ping');

    Result := totalping / NumPlayers;
end;


Your way is correct; the code in the original post breaks the rule of "Don't modify FOR counting variables inside a FOR loop", and is incorrect.

[szmon]

Thanks for tips. I still learning^^

[FliesLikeABrick]

It's a bit confusing i would write it this way:

Code: [Select]

function AveragePing(): integer;
var
    totalping, i: integer;
begin
    for i := 1 to 32 do
        totalping := totalping + GetPlayerStat(i,'Ping');

    Result := totalping / NumPlayers;
end;


Your way is correct; the code in the original post breaks the rule of "Don't modify FOR counting variables inside a FOR loop", and is incorrect.

... except the original code isn't using a for loop.  It is emulating a for-loop with a while-loop.  I don't believe there's anything wrong with his code from a "technically speaking" point of view

but yes, the other code is better

[EnEsCe]

It's a bit confusing i would write it this way:

Code: [Select]

function AveragePing(): integer;
var
    totalping, i: integer;
begin
    for i := 1 to 32 do
        totalping := totalping + GetPlayerStat(i,'Ping');

    Result := totalping / NumPlayers;
end;


Your way is correct; the code in the original post breaks the rule of "Don't modify FOR counting variables inside a FOR loop", and is incorrect.

... except the original code isn't using a for loop.  It is emulating a for-loop with a while-loop.  I don't believe there's anything wrong with his code from a "technically speaking" point of view

but yes, the other code is better

function AveragePing(): integer;
var
i : integer;
ping: integer;
totalping: integer;
begin
  for i := 1 to 32 do begin <<<<<<<<<<<<<<<
  totalping := totalping + GetPlayerStat(i,'Ping')
  i := i + 1
if i = 32 then
begin
ping := totalping / NumPlayers
end;
end;
Result := ping;
end;

wut?

[sai`ke]

Does getplayerstat return 0 if there is no player in that slot? If not, both will give a biased measure.

[szmon]

Does getplayerstat return 0 if there is no player in that slot? If not, both will give a biased measure.

corrected ;P

Code: [Select]

function AveragePing(): integer;
var
    totalping, i: integer;
begin
    if Numplayers > 0 then begin
    for i := 1 to 32 do
        totalping := totalping + GetPlayerStat(i,'Ping');

    Result := totalping / NumPlayers;
end;
end;


[mikembm]

LMAO szmon... just give up.