Help me with my simple script (not working)

[chutem]

I have been learning scripting on and off for a while now and understand most of it, i have looked at the specific functions and stuff at enesce.com/help, heck, i've even saved it all on my computer, I can also look at scripts and understand how they work, and can think about how I will write scripts in my head BUT, whenever I try to write them I get lots of errors.

This is a small script i tried to make so that I could make a larger one later:

Code: [Select]

function OnPlayerCommand(ID: Byte; Text: string): boolean;
if text = '/pos' then
WriteConsole(ID,'Your X ordinate is '  +inttostr(GetPlayerStat(ID,'X')),$FFFFFFFF);
WriteConsole(ID,'Your Y ordinate is '  +inttostr(GetPlayerStat(ID,'Y')),$FFFFFFFF);
end;
I have been looking at examples in other scripts plus the documantation and fixed about three errors, but now am stuck on one i can't find, even buy guessing where to put stuff.

This is such a small script, so it should be easy for one of the scripters to find me problem, anywho, the server shuts itself down when i try to run the script.
In the console log, this is the error:

• Pos -> [Error] (12:3): 'BEGIN' expected

Help is gonna be appreciated.

[Avarax]

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
    result:=false;
    if text = '/pos' then begin
        WriteConsole(ID,'Your X ordinate is '  + floattostr(GetPlayerStat(ID,'X')),$FFFFFFFF);
        WriteConsole(ID,'Your Y ordinate is '  + floattostr(GetPlayerStat(ID,'Y')),$FFFFFFFF);
    end;
end;

[chutem]

thanks avarax , but could u tell me when do I put in semicolons? is there a rule?.

Thats funny because in your trenchwar domination I copied the "if text = '/mine' then" bit and there was no begin.

Also, is that result:=False important? because I got that in the log but it said [hint], and what does it do.

Sorry if i'm asking alot of questions.

[chrisgbk]

Semicolons basically go at the end of every logical line.
ie:

Code: [Select]

IF true THEN
  doSomething
ELSE
  doSomethingElse;
While this is split over 4 lines, it's only one logical line.

BEGIN and END aren't needed if you are only using single statements; multiple statements require BEGIN and END as follows:

Code: [Select]

IF true THEN BEGIN
  doSomething;
  doSomethingElse;
END ELSE BEGIN
  doSomeOtherThing;
  doYetAnotherThing;
END;
Note that the statements in BEGIN and END require semicolons; BEGIN and END mark a block of code that is seperate from everything around it.

You should ensure that every possible call to your function produces an explicit return value; values aren't initialized to any default value, so it's possible if you never assign result to ie: false, it's possible it could have a value of true by default.

[chutem]

what does the value of result refer to?

[chrisgbk]

result is the return value of the function.

[saintpoida]

my understanding of result in the onplayercommand event

is that your telling it whether to pass the command on to soldat

for example

if someone types '/pos' which is what you are looking for then set Result := true;
to tell soldat that its a command that you are going to do stuff for this command so it shouldnt try execute it as well

if however it was  '/kill' then after you have checked your own commands if it is not one of yours return false and soldat will know to try and run this command itself...

this is how it seems to work IMO

[chrisgbk]

my understanding of result in the onplayercommand event

is that your telling it whether to pass the command on to soldat

for example

if someone types '/pos' which is what you are looking for then set Result := true;
to tell soldat that its a command that you are going to do stuff for this command so it shouldnt try execute it as well

if however it was '/kill' then after you have checked your own commands if it is not one of yours return false and soldat will know to try and run this command itself...

this is how it seems to work IMO

Read the manual, it tells you how the result of events is used; it varies by event.

[chutem]

f you're talking about enesce.com/help, then it doesn't even mention result

[chrisgbk]

f you're talking about enesce.com/help, then it doesn't even mention result

Yes it does, in the example for each function that returns a value.

[saintpoida]

Sorry i got to agree with chutem here...

The manual has no indication what OnPlayerCommand returns it does however specify what OnCommand returns, but if you had only just started looking you would probably miss that as i only just discovered it and i just used trial and error to work out what the return did.

[chrisgbk]

Guess that OnPlayerCommand had it left out, but it's the same as OnCommand:

begin
    if Text = '/test' then begin
       WriteLn('Test successful!');
    end;
    Result := false; // Return true if you want to ignore the command typed.
end;

ie: prevent further processing.