Procedures

[RunMan]

What is wrong with this one?
<6:1> Identifier needed

Code: [Select]

procedure OnPlayerCommand(ID: byte; Text: string);

begin

procedure WriteLol(Name: string);
begin
WriteConsole(ID,'You are LOL '+Name,$00AABBCC);
end;

if Text = 'lol' then
begin
WriteLol(RunMan);
end;

end;

[Avarax]

You can't have a procedure declared within another procedure. To do it properly, you have to place the whole WriteLol above OnPlayerCommand, like this:

Also make sure that RunMan is a declared string variable and that a value is assigned to it. Otherwise, write 'RunMan' instead of just RunMan in the WriteLol call.

Code: [Select]

procedure WriteLol(Name: string);
begin
  WriteConsole(ID,'You are LOL '+Name,$00AABBCC);
end;

procedure OnPlayerCommand(ID: byte; Text: string);
begin
  if Text = 'lol' then begin
    WriteLol(RunMan);
  end;
end;

[RunMan]

OK, but now when I write 'lol' nothing happens (I put RunMan into ')

[JFK]

That code shouldn't even compile i believe. The variable ID in WriteLol isn't assigned. Change it to 0 or include ID as input for your procedure.

[RunMan]

Ohh, I did it. Sorry I forgot to put changed code

Code: [Select]

procedure WriteLol(Name: string);
begin
  WriteConsole(0,'You are LOL '+Name,$00AABBCC);
end;

procedure OnPlayerCommand(ID: byte; Text: string);
begin
  if Text = 'lol' then
  begin
    WriteLol('RunMan');
  end;
end;

[JFK]

ahh. OnPlayerCommand only works when you do '/' instead of 't' ingame. So change 'lol' to '/lol' and type /lol ingame or change OnPlayerCommand to OnPlayerSpeak.

[RunMan]

Yeah, finally it works! Thank You very, very much

Oh, and be prepared for my another questions

@edit:

I made a script, everything is good, but now standard commands like /kill, /adminlog, /info don't work. I tried to put at the end of case:

Code: [Select]

else
end;
to end the script if player writes a command, which isn't in my list, but it didn't work.
Know how to make it work again?

[Boblekonvolutt]

You have to put begin before end...

[ghg]

"end else begin"
To be precise.

[danmer]

but now standard commands like /kill, /adminlog, /info don't work.

put

Code: [Select]

result := false;somewhere in there

[RunMan]

I don't understand. Can you explain it easier?

Code: [Select]

begin
case Text of
--commands--
end;
else
begin
result := false
end;
end;This one doesn't work

[JFK]

'end; else begin' is a faulty combination, you should use 'end else begin' without ;
But just put result := false before the last end; and let it always happen so:

Code: [Select]

begin
  case Text of
    --commands--
  end;
  result := false;
end;


[Boblekonvolutt]

Why even bother putting result := false?

[amb2010]

The result := false is what tells it to do the enable the command. With out it the defualt commands(/kill /mercy etc..) wouldnt work.

[Boblekonvolutt]

I know that, but it works fine without it...

[DorkeyDear]

I know that, but it works fine without it...

Thats because variables are default false, 0, or whatever.

[danmer]

Thats because variables are default false, 0, or whatever.

not always =F I think its highly recommended to reset your vars because of the nature of the language... Dont know the details, but it does act funny sometimes

[RunMan]

now it tells me unknown identifier 'result'

[danmer]

now it tells me unknown identifier 'result'

cause youre using OnPlayerSpeak, it doesnt return anything

[RunMan]

So how can I solve my problem?

I made a script, everything is good, but now standard commands like /kill, /adminlog, /info don't work.

[JFK]

Ok, let me try to explain. We work here with two different things: Procedures and Functions. The only difference between this two is that a Function will return a variable (a boolean, string, integer etc.). What the function returns is called the 'result'.
OnPlayerCommand is a function. This function will return a boolean (true or false). If it returns True then soldat will disable all commands accept the ones you discribe in OnPlayerCommand. Therefor you usually want to have result := false somewhere in the OnPlayerCommand function.
OnPlayerSpeak is a Procedure, it doesn't return anything. So if you put 'result' in OnPlayerSpeak the compiler will tell you that the identifier was not found.

[RunMan]

But I use OnPlayerCommands not OnPlayerSpeak

[JFK]

then really recheck your code. It should be a Function like this:

Code: [Select]

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
  --blabla, whatever here--
  Result := false;
end;

Result cannot be an unknown identifier then...

[RunMan]

Thanks, you are so cool

[DorkeyDear]

Thats because variables are default false, 0, or whatever.

not always =F I think its highly recommended to reset your vars because of the nature of the language... Dont know the details, but it does act funny sometimes

I found that 100% of the time in pascal that statement true, but not in other languages though.. Although it is good practice to set default values to variables.