BigTaunts

[Furai]

I skimmed through the script's code and I see it's well done but I have some buts ^^'. My point is that when someone (like me) have f.e. EFC and his position specified in separated lines it won't work as it should be. I'll paste here piece of my taunts file.

Code: [Select]

^<~EFC!~>
^<~On the left!~>
^<~Base HOT!~>
^<~Middle!~>
^<~Tunnel!~>
^<~High!~>
^<~Low!~>
© Furai

[Dr.Thrax]

yes this is not implemented
maybe its possible .. you would have the script to wait untill both taunts are written

[Furai]

Can it possibly write whole your phrase which you wrote?

[Dr.Thrax]

sure .. your text is saved in the "text" variable so you just have to output "text".
i was just searching for keywords in "text"

[Furai]

I see. Maybe I'll try to edit this script for my use. Of course if you don't mind.

[Dr.Thrax]

sure do it your way be free to use

[Furai]

Thanks. I don't know when I'll have time to do it, though.

[Gizd]

List of things I don't like:

1. Did you hear about type named 'boolean'? It has only 2 values: true and false, and is much more light than integer.
2. http://www.nopaste.com/p/agc9H7Bb9
Maybe you don't know that but too many RegExp's are quite(much) heavy. Putting them outside the for i:= 1 to 32 loop would help...
3. There's something named "else" that can prevent server from checking 50 if's everytime someone does /piss.
4.

Code: [Select]

if RegExpMatch('^\^.*(cap|score)',lowercase(Text)) = true then
...
                 DrawText(i,'Capture now!',(60*duration),RGB(0,255,0),iheight,iposx,iposy)Maybe "Score now!"?
5.

Code: [Select]

if (text = '/orange') then
        begin
          taunts_color := 5;
          WriteConsole(id,'BigTaunts-Color = Orange!',RGB(100,140,230));
        end;
...
if (taunts_color = 5) then
        begin
            color1 := 255;
            color2 := 150;
            color3 := 0;
        end;
What the ...? Can't you do:

Code: [Select]

if (text = '/orange') then
        begin
          color1 := 255;
          color2 := 150;
          color3 := 0;
          WriteConsole(id,'BigTaunts-Color = Orange!',RGB(100,140,230));
        end;
...and kick that variable?
Also you can use "case" instead of many ifs.
6. Why don't you use arrays in color/size/other settings?

And some good words to make you feel better even if you failed: You have some RegExp skillz

[Dr.Thrax]

I'll tell Timcrack , i didnt do anything about that new stuff but i see there is something that is really not necessary.
But Timcrack is new to the serverscripting and i think it's well done for that knowledge.
but thanks for your help

[y0uRd34th]

Code: [Select]

1. Did you hear about type named 'boolean'? It has only 2 values: true and false, and is much more light than integer.
Gizd: You only need to add '= True' or '= False' if the Result is an variant, if the Result, like in RegExpMatch is an Boolean you dont need to add it.

[tk]

y0uRd34th:
He meant using integer instead of boolean in the script:

p_taunts : array[1..32] of integer;

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
if (text = '/taunts') and (p_taunts[id] = 1) then
        begin
         p_taunts[id] := 0;
         WriteConsole(id,'BigTaunts disabled',RGB(100,140,230));
         end else if (text = '/taunts') and (p_taunts[id] = 0) then
                 begin
                 p_taunts[id] := 1;
                 WriteConsole(id,'BigTaunts activated!',RGB(100,140,230));
                 end;
...

When it should be

p_taunts : array[1..32] of boolean;

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
  if text = '/taunts' then
  begin
    p_taunts[id] := not p_taunts[id];
    writeconsole(id,'BigTaunts '+iif(p_taunts[id],'activated','disabled')+'!',RGB(100,140,230));
  end;
...

[y0uRd34th]

Oh, then ya.. He didn't had an example^^..

[Gizd]

Oh, then ya.. He didn't had an example^^..

Yes, that's why your post is useless.

[dragus]

Heh nice script

[Biggles]

Nice script I believe it could be quite useful for 6v6 games or higher, although I only read taunts when I'm waiting for the enemy to come into my base, otherwise I rather look around when i'm dead.