Question Thread

[Gizd]

- PunishBot (kicks spammers and bans them for x minutes (nearly finished)

You know there's a built-in anti-flood?

[DarkCrusade]

Yeah, you´d have a hang of what it will be like if I´d post what I´ve got until now. It´s WAY different.

From: April 18, 2010, 08:13:16 amThis is so basic that I am confused that it´s not working like this, because it should work to 100% ...

Code: [Select]

procedure OnJoinTeam(ID,Team:Byte); 
  begin
    if Team = 4 then begin
    Command('/setteam5 ' + ID);    <<<- THIS LINE RETURNS THE ERROR
    WriteConsole(ID,'Do not try to join the mutants. Please choose an other faction!', Red);
    WriteConsole(ID,'To see which factions are available and other commands type !help', Red);
  end;
end; 

As soon as I remove ID it´s working. I used Command like this before and it worked. Is it not working with this specific procedure? (Error = Type Mismatch)

[dnmr]

http://forums.soldat.pl/index.php?topic=37855.msg462039#msg462039

[DarkCrusade]

Next question: Why do I blame myself?

[dnmr]

Next question: Why do I blame myself?

because you should

[squiddy]

Dnmr is correct, DC.

Type Mismatches are errors that result when you have an integer value inside a string local, and vice-versa.

Also happens with float, and stuff.

Oh, well. Learn that.

Any more questions, feel free to ask :]

[Runny]

There's something weird with GiveBonus

I'm using GiveBonus with OnPlayerRespawn procedure. I can't say it doesn't work - as the result I can see 'Berserker Mode', 'Cluster nades', 'Predator mode', but I don't get these bonuses actually...

wtf?

[dnmr]

There's something weird with GiveBonus

I'm using GiveBonus with OnPlayerRespawn procedure. I can't say it doesn't work - as the result I can see 'Berserker Mode', 'Cluster nades', 'Predator mode', but I don't get these bonuses actually...

wtf?

onplayerrespawn is called before the player actually respawns. You'll need to set a flag var and give the bonus in AppOnIdle right after the player respawns

[Runny]

Thanks!

[DarkCrusade]

Is OnJoinGame called before OnJoinTeam?

And is there any possible way to disable more than one weapon with one line?

Solved (figured it out myself).

[Swompie]

Is OnJoinGame called before OnJoinTeam?

Try it yourself, put in these two proc, then write a msg which says which proc. was called, the first text appearing is the faster one.

[DarkCrusade]

Compiles, but there is an OutOfRange error OnMapChange and I don't know what could have caused it, any thoughts?

Code: [Select]

Procedure OnMapChange(NewMap: String);
var PlaID: Integer;
  begin
    for PlaID := 1 to 32 do
      Spamming[PlaID] := 0;
        if Warning[PlaID] > 0 then begin
          Warning[PlaID] := 0;
          WriteConsole(PlaID,'Your warning level was reset', Green);
     end;
  end;

[Swompie]

Out of range -> You are trying to access an index of an array which doesn't exists.

[croat1gamer]

PlaID has to be an array of integers or sth like that. Not just an integer.
You didnt define Warning and Spamming.

[Swompie]

PlaID has to be an array of integers or sth like that. Not just an integer.
You didnt define Warning and Spamming.

Then it'll say it's missing vars.

He just forgot to put an begin in the loop.

[squiddy]

He just forgot to put an begin in the loop.

Not really, he just forgot to check is PlaID is on server.

Code: (pascal) [Select]

OnMapChange();
For PlaID := 1 To 32 Do if GetPlayerStat(PlaID,'Active') = True Then
{ Statements }
End;


[DarkCrusade]

What is the best way to check a teams score? Because I've already tried different things with no real result other than that it failed. Also one of my admin commands worked before I summarized a procedure (pretty basic command, should work that way).

Necessary parts:

Code: [Select]

var
  ShowDmg: Boolean;

Code: [Select]

Function OnPlayerDamage(Shooter,Victim:Byte; Damage:Integer): Integer;
begin
  case GetPlayerStat(Shooter,'Human') of
    true: [...]
    false: [...]
  end;

  case GetPlayerStat(Victim,'Human') of
    true: [...]
    false: [...]
  end;

  if Player[Shooter].ShowDmg = true then
    WriteConsole(Shooter,'Output: ' + inttostr(Result), Red);
  if Player[Victim].ShowDmg = true then
    WriteConsole(Shooter,'Input: ' + inttostr(Result), Red);
end;And:

Code: [Select]

Function OnCommand(ID:Byte; Text:String):boolean;
var Piece1,Piece2,Piece3: String;
     Temp2,Temp3: Integer;
  begin
    Piece1 := GetPiece(Text,' ', 0);
    Piece2 := GetPiece(Text,' ', 1);
    Piece3 := GetPiece(Text,' ', 2);
    Temp2 := strtoint(Piece2);
    Temp3 := strtoint(Piece3);
  case Piece1 of
    '/showdmg': begin
      Player[ID].ShowDmg := not Player[ID].ShowDmg;
      WriteConsole(ID,'I/O messages got '+iif(Player[ID].ShowDmg=true,'enabled','disabled'),Black);
     end;
    [...]
  end;
The script has a size of ~1350 lines right now.

[squiddy]

Code: (pascal) [Select]

Var ShowDmg: Boolean;

Player[Shooter].ShowDmg; //This shouldn't work, because ShowDmg is a Global Variant, not an Array.

//~~~~~~~~~~~~~~~~~~~~~~
//To make that work, do this:

Type DC = Record
 ShowDmg: Boolean;
end;

Var
 Player: Array[1..32] of DC;

{ Statements }
 if Player[Shooter].ShowDmg = True; //Now we're talking about it!

//~~~~~~~~~~~~~~~~~~~~~~~~
//Although, if you are going to make only that Array, this should be faster and easier:

Var
 ShowDmg: Array[1..32] of Boolean;

{ Statements }

if ShowDmg[Shooter] = True; //Faster, if you only have one Array.

//Is a waste of time to create a Type Function for one Array.
Aaanyway....

@Topic:

This should work:

Code: (pascal) [Select]

Function GetTeamScore(Team: Byte): Integer;
 Var DC: Byte;
  Begin
   For DC := 1 To 32 Do if GetPlayerStat(DC,'Team') = Team Then Begin
  Result := GetPlayerStat(DC,'Flags');
 end;
end;

//I'm sure you can come up with some Command that activates GetTeamScore() Function. :)
//Good luck :D


[DarkCrusade]

@boolean issue: Sorry, I already did it like that. I have a big type for that stuff ...

Uhm ... could you explain me what 'GetPlayerStat(DC,'Flags');' returns? Because I looked it up at devs.soldat and didn't find it..

[Swompie]

NEVER, NEVER USE = true OR = false AGAIN EXCEPT FOR GetPlayerStat() STUFF.
When will people finally learn it

You fail Squiddy, besides that you forgot to check if the players are active the loop is really useless, wherefore is case and these TeamScore variables 

Code: [Select]

function GetTeamScore(Team: byte): integer;
begin
  case Team of
    1: Result := AlphaScore;
    2: Result := BravoScore;
    3: Result := CharlieScore;
    4: Result := DeltaScore;
  end;
end;
As for the command:

Code: [Select]

  case LowerCase(Piece1) of
    '/showdmg': begin
      Player[ID].ShowDmg := not Player[ID].ShowDmg;
      WriteConsole(ID, 'Damage displaying is now ' + iif(Player[ID].ShowDmg, 'enabled', 'disabled'), $FFFFFF);
    end;
  end;
This is the shortest and best way.

OnPlayerDamage():

Code: [Select]

  if Player[Shooter].ShowDmg then WriteConsole(Shooter, 'Base Dmg: ' + inttostr(Damage) + ' Out: ' + inttostr(Result) + ' dmg.' Red);
  if Player[Victim].ShowDmg then WriteConsole(Victim, 'Base Dmg: ' + inttostr(Damage) + ' In: ' + inttostr(Result) + ' dmg.' Red);

Regards Swompie.