Urgent Problem, needs fixing ASAP

[SpiltCoffee]

As mentioned earlier, HighestID is only implemented in the 2.7.0 ScriptCore. In the 2.6.5 ScriptCore, you will have to use something else instead (like 32).

[dnmr]

or make a custom function which calculates HighestID for you. You'll need to use it on player join/leave and on adding bots

[frosty]

or make a custom function which calculates HighestID for you. You'll need to use it on player join/leave and on adding bots

custom function not needed

all i really need is this, after defining HighestID as a variable:

Code: (pascal) [Select]

HighestID:=Numplayers+Numbots;

i think this would be better than just NumPlayers, although Numplayers is counting Bots also, Numplayers isnt just counting players its counting bots also

i had to do this in one of my scripts just to get the number of JUST players, this was done during a debug, now the script for it works perfect, without this line and PlayersActive being Numplayers that script is then a junk heap ><:

Code: (pascal) [Select]

PlayersActive := NumPlayers - Numbots
see? i had to subtract the number of bots from the number of players to get the ACTUAL number of players, else what i had set as an if would fail completely, thus, me saying: Numplayers ISNT just counting players its counting bots also

dnmr, was it you who said Numplayers was counting players only?

in case ur wondering this is what i found out during my debug:
http://pastebin.com/8kfbG17R

[Swompie]

You can't use NumPlayers either NumBots in either way to calculate the highest ID. Maybe there is a player with ID 20, and 12 humans or bots are on the server.
Anyway, that's the best & easiest way:

Code: (pascal) [Select]

function HighestID: byte;
begin
  for Result := 32 downto 1 do
    if GetPlayerStat(Result, 'Active') = true then
      break;
end;


[DorkeyDear]

Just do to 32, it is the easiest, and unless you have many many nested loops, it isn't going to be an issue when it comes to performance. And its easier to be sure the code is correct too. At least that's my opinion.

[frosty]

well if i do use 32, then if it comes across a number that doesn't match an id the script tends to "crash"

dunno why

ur code will prolly work better swompie

[SpiltCoffee]

If your code is crashing with 1 to 32, you're doing something wrong in your script. Using another number there is not the way to fix this problem.

[dnmr]

always check if the player is active before doing something with him, and you shouldnt have any problems

[frosty]

Code: (pascal) [Select]

Function Setteam(ID,Team:Byte):String;
begin
Command('/setteam'+Floattostr(Team)+' '+Floattostr(ID));
end;

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
if Text = '/red' then
begin
   Setteam(ID,1);
end;
end;

[8:11] syntax error

what?

[squiddy]

[...]
what?

Try this one.

Code: (pascal) [Select]

Procedure SetTeam(ID, Team: Byte);
 Begin
  Command('/setteam'+IntToStr(Team)+' '+IntToStr(ID));
end;

You don't need to use FloatToStr(). It's an Integer value, not a Float one

Although, I don't see the point at making this Procedure. It's just a line, ffs. Go Command() instead.

Well, I would. It's your choice.

[frosty]

Edit above

thanks tho squiddy

tho if i use Command it errors with numbers if its in the script that why i have to use a function

but now why am i getting a syntax error?

From: April 16, 2010, 05:56:30 pmnvm soon as i added ur code it stopped erroring

From: April 16, 2010, 06:01:56 pmactually no

Code: (pascal) [Select]

Procedure SetTeam(ID, Team: Byte);
begin
  Command('/setteam'+IntToStr(Team)+' '+IntToStr(ID));
end;

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
if Text = '/red' then
begin
   Setteam(ID,1);
end;

if Text = '/spec' then
begin
   Setteam(ID,5);
end;
end;

function OnCommand(ID: Byte; Text: string): boolean;
begin
if Text = '/blue' then
begin
   Setteam(ID,2);
end;

if Text = '/green' then
begin
   Setteam(ID,3);
end;

if Text = '/yellow' then
begin
   Setteam(ID,4);
end;
end;
1:34 colon expected

or i get unexpected end of file (3:32)

[squiddy]

[...]
tho if i use Command it errors with numbers if its in the script that why i have to use a function
[...]

I believe you meant that when you use Command() it crashes ?

Well, just go "Command('/setteam5 '+IntToStr(ID));", to change player ID to spectators.

Your welcome for the code.

Any more questions, feel free to ask

[frosty]

Code: (pascal) [Select]

var
Cash,DEC,DECC,Botn,EBNN,EBNND,EBNNT,EDMM,EDMMT,EDMMD:Integer;
BonusID,ID,EBN,EBNM,ED,EDM,DED,i:Byte;
Command:String;
deathexp,HC: Boolean;

function HighestID: byte;
begin
  for Result := 32 downto 1 do
    if GetPlayerStat(Result, 'Active') = true then
      break;
end;

[9:2] unexpected end of file
[9:2] syntax error

darn it >=(

[Swompie]

Did you try to start the server without HighestID code? Can't see any fails currently. Wther semicolon fails or such a thing, I've always got that error when I had an ´ or ` somewhere in the script placed out of a type mistake.

[frosty]

it only failed when i added the HighestID Code, yes i did try to start the server just before adding


but as soon as i comment it out it works fine so wtf

and i dont see any sytax errors, all working if statements that have a true or false answer are exact

[squiddy]

Try this:

Code: (pascal) [Select]

Function HighestID(): Byte;
 Var Dude: Byte;
  Begin
  For Dude := 32 DownTo 1 Do if GetPlayerStat(Dude,'Active') = True Then Break;
 Result := Dude;
end;

Always when you get such an errorr like that, write it all over again, with different Vars. Might help.

[frosty]

[2:2]syntax error
[2:2]begin expected

and if i move the var to the global vars i get this:

[3:2]syntax error
[3:2]unexpected end of file

which points to line 4 on your code since line 3 was moved and line 4 became line 3

[Swompie]

Can you post the whole code with HighestID, you don't have to (In normal code tags or attach w/e you like)
Maybe we can find the error, sth. must cause it since HighestID definetily isn't.
You use the server version 265?

[frosty]

it cant be because if thats the case even with HighestID uncommented it wont compile

it ONLY compiles if HightestID is COMMENTED OUT, at the moment its working perfect, ONLY because i have HighestID commented out, anyways heres the full script:

http://pastebin.com/hwRnkARG

it IS compiling but WILL NOT compile with HighestID uncommented

and yes i do believe that the server host is using 265

[Swompie]

Any other scripts? For me it just compiles fine..