Difference?

[Diretlani]

A partner and i have been working on a server ultimately.. "! [ Saw & Law ] !".

We needed an anti-bloodsaw script and didn't found one, so we used our common sense and intelligence to make one, and yay it works xD!

I wanna know your opinions of these "scripts".. both work perfectly.

Code: [Select]

function OnPlayerCommand(ID: Byte; Text: string): boolean;
var i: integer;
begin
     if Text = '/mercy' then begin
          for i := 1 to 1 do begin
               if GetPlayerStat(i, 'active') then Command('/kill '+GetPlayerStat(ID, 'Name'));
          end;
     end;
end;
And the one that is running on the server, lol:

Code: [Select]

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
     if Text = '/mercy' then begin
                Command('/kill '+GetPlayerStat(ID, 'Name'));
          end;
     end;
What's the difference between using and not using the variable..?

[SpiltCoffee]

What the fudgebar?! You're not even using the for loop! Tell me who wrote the top script so I can go over to them and slap them in the face for 1 to 1 times.

EDIT: In fact, the top one has a logic error induced by the use of the for loop. Use the bottom one.

[chutem]

In the first one you are always checking if the ID 1 is active, which is useless. Not to mention you are using a loop that loops from 1, ..... to 1. One loop, you know, you could just put the line of code in and it would do the same damn thing...

[Gizd]

This one's better:

Code: [Select]

if GetPlayerStat(ID,'Alive) = true then if GetPlayerStat(ID,'Primary') = 15 then DoDamage(ID,6666);(put that in the place of Command(...))

[squiddy]

This one's better:
[...]

You forgot the closing ' after "Alive"..

Complementing Gizd's Script..

Code: [Select]

Function OnPlayerCommand(ID: Byte; Text: String);
 Begin
  Text := LowerCase(Text);
   if Text = '/mercy' Then Begin
  if GetPlayerStat(ID,'Alive') = True Then if GetPlayerStat(ID,'Primary') = 15 Then DoDamage(ID,6666);
 end;
end;

[Diretlani]

This one's better:
[...]

You forgot the closing ' after "Alive"..

Complementing Gizd's Script..

Code: [Select]

Function OnPlayerCommand(ID: Byte; Text: String);
 Begin
  Text := LowerCase(Text);
   if Text = '/mercy' Then Begin
  if GetPlayerStat(ID,'Alive') = True Then if GetPlayerStat(ID,'Primary') = 15 Then DoDamage(ID,6666);
 end;
end;

Lol.. why use DoDamage if you can just use /kill id ?

Just to make clear..

var i: integer;     CREATES THE VARIABLE i
for i := 1 to 1 do begin      THIS LINE CHECKS PLAYERS IDS right? if my server has 12 slots, it should be for i := 1 to 12?

I am saying if i use a loop and my server has 12 slots should i do 1 to 12?, becuz in all the scripts is 1 to 32, and 32 is the player limit for anyserver, right?

[SpiltCoffee]

No no no no no NO.

Listen, and listen careful, for I will only explain this once (although several other people will probably do it too).

OnPlayerCommand(ID: Byte; Text: String);

ID is the ID of the player who typed a command.
Text is the command that they sent.

Therefore, imagine if player 3 typed /mercy, the ScriptCore would call OnPlayerCommand with ID being 3 and Text being '/mercy'. You do NOT have to use a for loop to determine which player to kill, because you get given the player's ID when the function itself is called.

That is why the for loop is not only useless, it also creates a logical error in your script, because, in the first example, you're checking to see if the first player is alive, and THEN killing the player who sent it, so if player 1 is dead, player 3 wouldn't be killed when he types '/mercy'.

In the second example you provided for your want of a for loop, you're now checking against all players to see if any one of them are alive. That means you'll be killing him each time you find a player alive. If you have a 12 slot server, and everyone is alive, and someone does /mercy, he's gonna get killed 11 times in that situation. Or, if I've misunderstood how many times you want to use that i variable, doing your second example could result in a script that kills ALL players when one types /mercy.

Moral of the story (also TL;DR): Don't use a for loop for this script.

[Diretlani]

No no no no no NO.

Listen, and listen careful, for I will only explain this once (although several other people will probably do it too).

OnPlayerCommand(ID: Byte; Text: String);

ID is the ID of the player who typed a command.
Text is the command that they sent.

Therefore, imagine if player 3 typed /mercy, the ScriptCore would call OnPlayerCommand with ID being 3 and Text being '/mercy'. You do NOT have to use a for loop to determine which player to kill, because you get given the player's ID when the function itself is called.

That is why the for loop is not only useless, it also creates a logical error in your script, because, in the first example, you're checking to see if the first player is alive, and THEN killing the player who sent it, so if player 1 is dead, player 3 wouldn't be killed when he types '/mercy'.

In the second example you provided for your want of a for loop, you're now checking against all players to see if any one of them are alive. That means you'll be killing him each time you find a player alive. If you have a 12 slot server, and everyone is alive, and someone does /mercy, he's gonna get killed 11 times in that situation. Or, if I've misunderstood how many times you want to use that i variable, doing your second example could result in a script that kills ALL players when one types /mercy.

Moral of the story (also TL;DR): Don't use a for loop for this script.

Thank you very much :3

I have to say, we noticed the globalkill effect by using 1 to 12, and using /mercy lol.

It was funny to see how, all people dies because of us doing /mercy.

[Gizd]

Lol.. why use DoDamage if you can just use /kill id ?

Because it's better?

[DorkeyDear]

'/kill <id>' writes to the player console (and console too im pretty sure). therefore DoDamage has more control on exactly what you want.

[squiddy]

Just lik DorkeyDear said, /kill command writes a message to all players.

DoDamage() doesnt.

Just go DoDamage(ID,4000); that it kills player right on time :]

[Diretlani]

Just lik DorkeyDear said, /kill command writes a message to all players.

DoDamage() doesnt.

Just go DoDamage(ID,4000); that it kills player right on time :]

But, i want to show the killed by admin msg to other players.

When someones do /mercy it kills the player and 2 msg appears:

%player% killed by admin
BloodSaw is not allowed.

That's a warn for the other noobs thinking about doing /mercy..

[Neosano]

Well, a bad idea. They'll flood chat with these stupid shiny messages...
If someone wants to try it - why not?

[squiddy]

Well, a bad idea. They'll flood chat with these stupid shiny messages...
If someone wants to try it - why not?

I am with you.

When players look at the death console, they will be all like, omg, did he died trying to do /mercy ?

Then they go and do /mercy.

And they die.

And then more noobs try to do /mercy, and there it goes.

[Gizd]

Well, a bad idea. They'll flood chat with these stupid shiny messages...
If someone wants to try it - why not?

I am with you.

When players look at the death console, they will be all like, omg, did he died trying to do /mercy ?

Then they go and do /mercy.

And they die.

And then more noobs try to do /mercy, and there it goes.

Your server is made for retards? D:

[croat1gamer]

Code: [Select]

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
if Text = '/mercy' then begin
DoDamage(ID,ID,8001);
WriteConsole(ID,'Dont do that.',$EE81FAA1);
WriteConsole(0,'Dont /mercy kids. '+ IDToName(ID) +' learned why.' ,$EE81FAA1);
SetScore(ID,0);
end;
end;
As simple as possible.
Added the mass message.

[Diretlani]

Thanks for all the comments, and codes <3

But i'm using /kill if you don't mind ._.

[croat1gamer]

Code: [Select]

function OnPlayerCommand(ID: Byte; Text: string): boolean;
begin
if Text = '/mercy' then begin
Command('/kill ' + ID);
WriteConsole(ID,'Dont do that.',$EE81FAA1);
WriteConsole(0,'Dont /mercy kids. '+ IDToName(ID) +' learned why.' ,$EE81FAA1);
SetScore(ID,0);
end;
end;