Scripting Suggestions

[dnmr]

Anyone else than me wants plain bullets spawned through CreateBullet() visible to anyone no matter which weapon he carries?

of course

[DarkCrusade]

DoDamage should return the bulletstyle.
OnPlayerSpeak should return a boolean also to mute players/disable commands.

[Gizd]

DoDamage should return the bulletstyle.

How would that be any useful?

[DarkCrusade]

Imagine >.<

For example you wouldn't need to change the weapons.ini to change damage dealt by certain guns.
Or set the damage to 0 for certain conditions like a that makes you invincible to CERTAIN bullets.
So much stuff you could do ...

[SpiltCoffee]

Do you mean OnPlayerDamage? Because DoDamage is a procedure, and even if it was a function, anything it returns (besides maybe how much of the player's health was lost?) would be useless.

[DorkeyDear]

Edit my ReadDataFile suggestion please:
function ReadBinaryFile(const Filename: string): string;
Identical to ReadFile, except that it ignores the feature where it stops reading once it reaches the character 0x1A (26 dec).
http://forums.soldat.pl/index.php?topic=35628.0
http://forums.soldat.pl/index.php?topic=26661.msg428455#msg428455

I think everybody has been wishing for the OnPlayerSpeak event to no longer being threaded (reason why it cannot return a value), and to allow it to return a boolean, which action is very similar to OnCommand and OnPlayerCommand return values. That is, allowing or disallowing the message to be relayed to all the other clients. (This was in addition to DarkCrusade's comment)
http://forums.soldat.pl/index.php?topic=26661.msg327943#msg327943 - Also includes another idea: having the Text parameter of OnPlayerSpeak be reference variable, so it can be edited. This also requires OnPlayerSpeak to not be threaded.

Some topic on Soldat Forums mentioned:
function GetWaypointStat(const WId: byte; const Stat: string): variant;
procedure SetWaypointStat(const WId: byte; const Stat: string; const Value: variant);
But it can be understandable the reason why these would not be implemented. It would require sending waypoint data after players have already joined. Since you cannot manipulate the server (with scripting) so only certain players only see certain things (like bots following a waypoint), you cannot edit the waypoints; otherwise, there would be complications of what one player sees compared to another player sees a bot doing.
It would probably also take a lot of effort to edit the code such that certain bots can only follow certain waypoints, but that would be an interesting idea to see.
http://forums.soldat.pl/index.php?topic=26661.msg426548#msg426548
http://forums.soldat.pl/index.php?topic=22560.msg262527#msg262527

This topic provides many other suggestions which could be added to the list, if you want.

This is more of a bug fix request, but I'll mention it anyways: INCLUDE pre-processor directive would be nice if it were working.
{$INCLUDE ./shared/binary.pas}

[DarkCrusade]

Do you mean OnPlayerDamage? Because DoDamage is a procedure, and even if it was a function, anything it returns (besides maybe how much of the player's health was lost?) would be useless.

Sorry, yeah I was talking about OnPlayerDamage.

[Swompie]

Updated & heavily edited my first post, I like it much more now 

[LORD KILLA]

This dies,

[DarkCrusade]

What about this:

Code: (pascal) [Select]

Function OnHit(ID,Bullet:Byte):Boolean;    // ID: Player being hit, Bullet: ID of the bullet
begin
  Result := false;                                  // set to true to cancel hit registration
end;
OnHit triggers whenever a player is hit by a bullet. The only thing it does is manipulating the hit registration. This way you are able to neglect the instant kill effect of M79 and LAW or not getting pushed by shotgun pellets. There would be new possibilities for RPG mods either (like some skill that turns you into dust, you get invisible and bullets just fly through you)

Code: (pascal) [Select]

Function OnPolygonTouch(ID,Type:Byte):Boolean;    // ID: Player who touches a polygon
begin                                                                // Type: Polygon type
  Result := false;                                                 // set to true if he shall fall through
end;
Allow different players different paths or special places (mainly for new subgame modes / RPGs)

[Gizd]

@up

• There will be no procedure which triggers whenever a player shoots.
• There will be no event which triggers each tick or millisecond.

Idk how would the OnPolyTouch be implemented but I guess it would trigger really really often.

[DarkCrusade]

OnHit wouldn't trigger whenever someone shoots. It'll trigger whenever a player is being hit :3

[Gizd]

OnHit wouldn't trigger whenever someone shoots. It'll trigger whenever a player is being hit :3

That won't change frequency a lot.

[Swompie]

OnHit wouldn't trigger whenever someone shoots. It'll trigger whenever a player is being hit :3

That won't change frequency a lot.

How 'bout OnPlayerDamage.
And still it wouldn't be possible to negate the insta-kill explosives, because it still had to be removed the hardcoded part..

[Hacktank]

OnHit wouldn't trigger whenever someone shoots. It'll trigger whenever a player is being hit :3

That won't change frequency a lot.

How 'bout OnPlayerDamage.
And still it wouldn't be possible to negate the insta-kill explosives, because it still had to be removed the hardcoded part..

Ohh, but you can now. I figured out how!

When your hit with a law/m79 it automaticly setts your health to somewhere around -300 through -400. But you can completly negate this in onplayerdamage() by using result := -)getplayerstat(victim,'health') - DAMAGEYOUREALLYWANT). It works perfectly.

[DarkCrusade]

Or you just set a bullets damage to -99999 and set the health back to the original value in OnPlayerDamage

[Hacktank]

That is pretty much exactly what i just said. Also I am talking current release version w/o setplayerstat(). Which will fail unless it has: health, vest, primary/secondary ammo, nades, and jet.

[DarkCrusade]

More:

Code: (pascal) [Select]

GetPlayerStat(ID,'Programmes'); // Returns the amount of programs running behind Soldat
GetPlayerStat(ID,'TimeConnected'); // Returns the time (in seconds) a player is connected
Makes things easier

[dnmr]

wtf is programmes.. why would you need it?
And you can calculate timeconnected with two lines of code <.<

[DarkCrusade]

First: Just some random idea that came up to me when I worked on AntiCheat :3
Second: Coders are lazy, man