Frosty's scripting thread

[frosty]

thanks

From: September 14, 2010, 04:10:25 amGRR

second attempt at nuke turret, failed miserably, for some reason its arming straight away, should be a 10 second countdown, and it should be firing when armed, its not triggering at all

using arrays, what am i missing? what am i doing wrong? its gotta be something stupid cuz its driving me NUTS, look in Apponidle, not even the writeln message is appearing and i dont get why

plz tell me what im doing wrong here
custom functions available in utils.pas and bang.pas

[frosty]

Enesce server hosting, worst host ever

all i need is one script with a DoDamage and then he claims that my server is using too much CPU, well just for Arguments sake, NO OTHER SCRIPTS are even compiling, (what i wanted)

now i know what half my problems are

and all he (nick) is using is a Quad Core CPU and some other cheap n nasty upgrade, he should be using i7 quad cores fcs

seen quite a few posts on the forum complaining about something similar but all related

enesce hosting

the hardware is just.....inadequate, little wonder people are having trouble, still waiting on an email from U13 so i can get it set up there

[tk]

When looking at your "scripts", I'm not surprised why he refuses to host them.
Quad Core CPU is enough for dozen soldat servers.

[dnmr]

When looking at your "scripts", I'm not surprised why he refuses to host them.
Quad Core CPU is enough for dozen soldat servers.

what he said ^

You probably had an infinite loop in there or something similar -.-

[EnEsCe]

Dual Quad Core actually, Frosty (like it says on the front page when logging in)... Why are you only just now posting about something that occurred 4 months ago and hasn't been a problem since? But anyway, as I mentioned to you in one of the original emails, your server was the ONLY one using 100% CPU, while the other heavily scripted zombie servers weren't. Your scripts were the cause, not server hardware or "just" DoDamage.

[frosty]

well one reason i havent posted is because some idiot decided to get nasty so i gave up on dodamage, that was also 4 months ago just after the upgrade

DarkCrusade if you havent got anything helpful to say then dont say it, please...

well then can someone please go over this script? (attached) whats causing so much cpu usage?, at the moment cpu usage isnt a problem
however, as soon as i add a dodamage to this script, even just as a coommand where its only affecting ID not i out of 1 to 32 or whatever, it jumps to 100%, makes no sense since the average is 15%, thats what im saying, why would one line of dodamage cause so much cpu usage

there must be something seriously retarded with it, please point it out, id be very grateful if you could

just tried out dodamage by itself, not a problem, so there must be something in this script causing it to do that (only one im having trouble with)

please CONSTRUCTIVE criticism only!

Includes.txt also attached

[DarkCrusade]

What the fuck I didn't say anything, but now you make me post something you might don't want to hear. You want "constructive criticism", but for what? If you want features to be discussed, why do you ask for help with fixing bugs? One reason why everyone is pissed and trolling this topic is, that you are one of the worst programmers (if you deserve that title) I have seen in my entire lifetime. Everytime I view one of your buggy scripts I find errors that I have seen months ago somewhere else. You don't learn anything, and that should tell you you should stop. Sorry, but just find a new hobby.

[dnmr]

What the f**k I didn't say anything, but now you make me post something you might don't want to hear. You want "constructive criticism", but for what? If you want features to be discussed, why do you ask for help with fixing bugs? One reason why everyone is pissed and trolling this topic is, that you are one of the worst programmers (if you deserve that title) I have seen in my entire lifetime. Everytime I view one of your buggy scripts I find errors that I have seen months ago somewhere else. You don't learn anything, and that should tell you you should stop. Sorry, but just find a new hobby.

nice rage.

* dnmr approves

Now for something more or less constructive. frosty.. You are using 6 scripts and you probably don't even realize how they work and if they are compatible at all :/

[frosty]

dnmr how do i figure out if they are compatable?

and they are all used in the main scripts: Shop.pas and utils.pas

but sofar i have found nothing on the forum about "compatability" maybe i havent looked hard enough

DarkCrusade why did i post that? because all you did was troll for at least half the topic, not helping the situation at all, like you did just then, edit: btw since when is asking for scripting help in the SCRIPTING HELP AND DISCUSSION thread trolling?? u make no sense, going off like an idiot isnt HELPING either, i mean, if youve seen the bugs elsewhere like you claim then why not LINK to them at least???

or how other ways can i learn the pascal language, since i cant afford to do any courses for the real ones just yet

maybe i should spend a few months going through all the bugs pages....

[Falcon`]

If your script eats AVERAGE OF 15% of cpu and you think that's low, then you have my personal congratulations sir!

[frosty]

well, the whole server, im using like 20 scripts all up and the whole server uses an average of 10-15%

but seriously, how much CPU is a server "supposed" to use, and again how can i lower the usage? ive tried putting repeating code into functions and procedures, thats lowered it a little bit, i cant find anything on the net on how to shrink cpu usage of a pascal program, only can find how to write one and what the default syntax is, and a LITTLE bit on troubleshooting

[DarkCrusade]

You didn't understand what I said. My last post (before my rage) was on the 13th September. You replied to it being thankful. Now - months later - you tell me to shut up, because all I do is trolling and not helping. Why? I was the person helping you the most back then, when everyone else refused to because they were driven bonkers by what's making me mad right now. Your understanding of programming is that you put some code here and put some code there and it'll work the way you propose. Even if your code works, putting different code into different scripts won't help in any way, it rather makes everything worse. Many scripts instead of a single big one eat CPU and can cause servercrashs. Besides, it's just dumb, because it's harder to fix bugs, and it's even harder for someone who is starting with Soldat scripting to learn real programming.

Please, learn Pascal. Give it a harder try. There are books in libraries written in your language out there. It's the best for you.
 

[frosty]

ok, thankyou

[tk]

but seriously, how much CPU is a server "supposed" to use

0-1%

Let's look at one of your scripts

Code: [Select]

    for i:= 1 to 32 do if Getplayerstat(i,'Ping') > 0 then begin
      if SpeedTimer[i] > 0 then Speedtimer[i] := SpeedTimer[i] - 1;
      iniWrite('Players/'+IDtoname(i)+'.ini','stats','kills',inttostr(playerinfo[i].kills));
      iniWrite('Players/'+IDtoname(i)+'.ini','stats','tupred',inttostr(TUPred[i]));
      iniWrite('Players/'+IDtoname(i)+'.ini','stats','barkills',inttostr(barKills[i]));
      iniWrite('Players/'+IDtoname(i)+'.ini','stats','ranknum',inttostr(RankNum[i]));
    end;
...
 For z := 1 To ItemID Do begin
    if ItemInfo[z].Name='Massive Flak Gun' then begin
      for i := 1 to 32 do if (CheckPlayerDist(i,ItemInfo[z].x,Iteminfo[z].y,600)) AND (GetPlayerStat(i,'Team')<>ItemOwner[z].Team) then Shoot(ItemInfo[z].x,Iteminfo[z].y,GetPlayerStat(i,'x'),GetPlayerstat(i,'y'),500,1000,4,ItemOwner[z].PlayerID);
    end;
    if ItemInfo[z].Name='Auto Turret' then begin
      for i := 1 to 32 do if (CheckPlayerDist(i,ItemInfo[z].x,Iteminfo[z].y,600)) AND (GetPlayerStat(i,'Team')<>ItemOwner[z].Team) then Shoot(ItemInfo[z].x,Iteminfo[z].y,GetPlayerStat(i,'x'),GetPlayerstat(i,'y'),5000,1000,1,ItemOwner[z].PlayerID);
    end;

  for i := 1 to 32 do if (CheckPlayerDist(i,ItemInfo[z].x,Iteminfo[z].y,50)) AND (idtoname(i) = 'Mr.Zombie') then begin
and so on, and so on...
HORRIBLE way of coding, total lack of optimization, multiple loops with thousands of iterations, spaming with functions such as GetPlayerStat, checking distances and using heavy ini functions every second. How can you even ask why it has so big cpu use?

[frosty]

could someone please tell me why this is giving me an identifier expected error?

refined and fixed, only thing is i cant find whats causing this error, cant see any missing ';'

no missing begins or ends, otherwise my notepad++ would have told me about it

Shop -> [Error] (777:25): Identifier expected

maybe theres something else i need to take note of, all help appreciated

error located in Shop.pas (as far as i can tell)

maybe the script is corrupt? :S

btw to answer a previous question, ive got the code split up to make it easier to work on, that way im not scrolling through a thousand lines just to find something, (cant remember the actual code so ctrl+f is out of the question as the search would error "cannot find")

waiting on a few pascal books which i ordered over the net btw

another question, in one of my online references, it says that the Case argument is limited, just how "limited" is it exactly:

Pascal for beginners - Part 2

somehow i dont think that page is quite complete, but mind you it is several years old...

i tried using it, but after 4 or 5 case statements in the one Case...of it gives me a syntax error

could someone please enlighten me to exactly how many Case arguments you can fit into a case of statement

Code: (pascal) [Select]

Case Number of
1: ok;
2: ok;
3: ok;
4: maybe;
5: error;
end;
[/randommadeupcode]

thanks in advance

[Boblekonvolutt]

btw to answer a previous question, ive got the code split up to make it easier to work on, that way im not scrolling through a thousand lines just to find something, (cant remember the actual code so ctrl+f is out of the question as the search would error "cannot find")

No, it's cause you're combining a number of scripts you don't actually understand and can't combine it. What you really should do is start from scratch and not allow yourself to copy anything from anywhere.

If you actually think about how you could get the information from the line number given by the soldat server the answer is pretty obvious.

(Line 136 in Shop.pas, I should add if I'm gonna be realistic)

[DarkCrusade]

Case statements are not limited, and the tutorial doesn't imply that. It just needs to end somewhere, and because you cannot add a ';' at the end you add an 'end;'.

[frosty]

so ill have to make my own ini writing and shooting procedure, i hope that pascal book comes in soon, i wonder how im going to remake that nova..

ill get there eventually i guess

thanks guys

From: January 01, 2011, 07:41:13 pmi have another problem, one of my functions is calling a type mismatch error, compare the working code with the not working code

the function:

Code: (pascal) [Select]

function CheckPlayerAdmin(ID:Byte):Boolean;
begin
if ReadINI('Players/'+IDtoname(ID)+'.ini','stats','admin','0') = '1' then Result:=True;
end;
working code:

Code: (pascal) [Select]

function OnPlayerDamage(Victim, Shooter: byte; Damage: integer): integer;
begin
  Playerinfo[Shooter].achievements:=strtoint(ReadINI('Players/'+IDtoname(Shooter)+'.ini','stats','tna','0'));
  DamagePerc[Shooter]:=(RankNum[Shooter]*RankDamageMult)+Playerinfo[Shooter].achievements;
  if {CheckPlayerAdmin(Shooter)=True and }Getplayerstat(Victim,'alive') then CreateBullet(GetPlayerStat(Victim,'x'), GetPlayerStat(Victim,'y') - 0, 0,0,1, 10, Shooter);
  RankDam[Shooter]:=Damage+(Damage*(DamagePerc[Shooter]/100));
  result:=Damage + Rankdam[Shooter];
  if IDtoname(Shooter) = '[Warlord]Mr.Zombie' then begin
    DamCalc[Shooter]:=Damage+RankDam[Shooter];
    //Result:=DamCalc[Shooter]*(1/100);
  end;
end;
not working:

Code: (pascal) [Select]

function OnPlayerDamage(Victim, Shooter: byte; Damage: integer): integer;
begin
  Playerinfo[Shooter].achievements:=strtoint(ReadINI('Players/'+IDtoname(Shooter)+'.ini','stats','tna','0'));
  DamagePerc[Shooter]:=(RankNum[Shooter]*RankDamageMult)+Playerinfo[Shooter].achievements;
  if CheckPlayerAdmin(Shooter) and Getplayerstat(Victim,'alive') then CreateBullet(GetPlayerStat(Victim,'x'), GetPlayerStat(Victim,'y') - 0, 0,0,1, 10, Shooter);
  RankDam[Shooter]:=Damage+(Damage*(DamagePerc[Shooter]/100));
  result:=Damage + Rankdam[Shooter];
  if IDtoname(Shooter) = '[Warlord]Mr.Zombie' then begin
    DamCalc[Shooter]:=Damage+RankDam[Shooter];
    //Result:=DamCalc[Shooter]*(1/100);
  end;
end;
ALSO not working:

Code: (pascal) [Select]

function OnPlayerDamage(Victim, Shooter: byte; Damage: integer): integer;
begin
  Playerinfo[Shooter].achievements:=strtoint(ReadINI('Players/'+IDtoname(Shooter)+'.ini','stats','tna','0'));
  DamagePerc[Shooter]:=(RankNum[Shooter]*RankDamageMult)+Playerinfo[Shooter].achievements;
  if CheckPlayerAdmin(Shooter)=True and Getplayerstat(Victim,'alive') then CreateBullet(GetPlayerStat(Victim,'x'), GetPlayerStat(Victim,'y') - 0, 0,0,1, 10, Shooter);
  RankDam[Shooter]:=Damage+(Damage*(DamagePerc[Shooter]/100));
  result:=Damage + Rankdam[Shooter];
  if IDtoname(Shooter) = '[Warlord]Mr.Zombie' then begin
    DamCalc[Shooter]:=Damage+RankDam[Shooter];
    //Result:=DamCalc[Shooter]*(1/100);
  end;
end;
can anyone expain why this isnt working and why it has all of a sudden decided to error? its always worked up til now, i havent touched that section of code in my clean up so what the f*** :S

[Falcon`]

store this admin value in some variable. With current code you're raping your hard drive each hit. Also 2nd code should work (this w/o =true). if it really doesn't then try "if (CheckPlayerAdmin(Shooter) = true) and ...".

Also admin advantage idea is ingenious. I think i said it already but i guess players hate/try to kick you for that every time you join lol.

[frosty]

wtfffffff??
looks like the entire shop script is broke, or do i need to rewrite it (again)

can anyone see whats going on?

Shop -> [Error] (762:39): Type mismatch

i dont have much time to go through it properly

but the thing is, if i comment out OnPlayerCommand, the error automatically points to the next uncommented line

it sems no matter how many lines i comment out, i cant find the error, or is it, like you guys said, an imcompatability in the code = give up on shop and use my own functions?

im sorry about this guys