OnPlayerDamage

[dominikkk26]

Yo I've got some script and there is something wrong, however, start the script variables sometimes mixed with other functions shows buguja and are in working order.
The Annex gives the code.

Code: (passcal) [Select]

function OnPlayerDamage(Victim,Shooter: Byte;Damage: Integer): integer;
var
tmpDmg: double;
i: byte;
begin
for i := 1 to MAXPLAYER do
begin
tmpDmg:=Damage;
if(tmpDmg>=0)then begin
NDamage := Damage;
UpdateServStats();
UpdateNickname(GetPlayerStat(i,'name'),i);
if ShowDamage = 'true' then begin
if Language[Shooter] = 'EN' then WriteConsole(Shooter,'Victim: '+GetPlayerStat(Victim,'Name')+' Dmg = '+floattostr(tmpDmg),Good);
if Language[Victim] = 'EN' then WriteConsole(Victim,'Inflicting damage: '+GetPlayerStat(Shooter,'Name')+' Dmg = '+floattostr(tmpDmg),Bad);
if Language[Shooter] = 'PL' then WriteConsole(Shooter,'Ofiara: '+GetPlayerStat(Victim,'Name')+' Dmg = '+floattostr(tmpDmg),Good);
if Language[Victim] = 'PL' then WriteConsole(Victim,'Otrzymane obrarzenia: '+GetPlayerStat(Shooter,'Name')+' Dmg = '+floattostr(tmpDmg),Bad);
end;
NDamageZ[Shooter] := Round(tmpDmg);
NDamageO[Victim] := Round(tmpDmg);
UpdateNickname(GetPlayerStat(i,'name'),i);
if not NDamageZ[Shooter] = 0 then begin
NDamageZ[Shooter] := 0;
end;
if not NDamageO[Victim] = 0 then begin
NDamageO[Victim] := 0;
end;
end;
Result:=Round(tmpDmg);
end;
end;

[kicikici]

I wonder what is so important in function UpdateNickname(GetPlayerStat(i,'name'),i); that is called 2 times in each loop.
Also why all code in OnPlayerDamage is inserted in loop : for i := 1 to MAXPLAYER do when only one function UpdateNickname(GetPlayerStat(i,'name'),i); reffer to variable i.
I think that this things could cause problem - OnPlayerDamage is called a many many times and have a lot to do.

[dominikkk26]

It just does not matter already checked.
The problem is that the variables in the mix
NDamageZ - damage done
NDamageO - damage incurred

I guess I wrote it wrong I wrote this renewal (code below)

Code: [Select]

var
tmpDmg: double;
MaxHealth, Otrzymane: integer;
begin
tmpDmg := Damage;
NDamage := Damage;
MaxHealth := iif(Command('/realistic')='1',65,150);
Otrzymane := MaxHealth-(Damage*100/MaxHealth);
UpdateServStats();
if (Victim <> Shooter) then begin
if Language[Shooter] = 'EN' then begin
if ShowDamage = 'true' then WriteConsole(Shooter,'Victim: '+GetPlayerStat(Victim,'Name')+' Dmg = '+floattostr(tmpDmg),Good);
NDamageZ[Shooter] := Round(tmpDmg);
if(GetPlayerStat(Shooter,'Active')=true) then begin
UpdateNickname(GetPlayerStat(Shooter,'name'),Shooter);
if not NDamageZ[Shooter] = 0 then NDamageZ[Shooter] := 0;
end;
end;
if Language[Victim] = 'EN' then begin
if ShowDamage = 'true' then WriteConsole(Victim,'Inflicting damage: '+GetPlayerStat(Shooter,'Name')+' Dmg = '+floattostr(tmpDmg),Bad);
NDamageO[Victim] := Otrzymane;
if(GetPlayerStat(Victim,'Active')=true) then begin
UpdateNickname(GetPlayerStat(Victim,'name'),Victim);
if not NDamageO[Victim] = 0 then NDamageO[Victim] := 0;
end;
end;
if Language[Shooter] = 'PL' then begin
if ShowDamage = 'true' then WriteConsole(Shooter,'Ofiara: '+GetPlayerStat(Victim,'Name')+' Dmg = '+floattostr(tmpDmg),Good);
NDamageZ[Shooter] := Round(tmpDmg);
if(GetPlayerStat(Shooter,'Active')=true) then begin
UpdateNickname(GetPlayerStat(Shooter,'name'),Shooter);
if not NDamageZ[Shooter] = 0 then NDamageZ[Shooter] := 0;
end;
end;
if Language[Victim] = 'PL' then begin
if ShowDamage = 'true' then WriteConsole(Victim,'Otrzymane obrarzenia: '+GetPlayerStat(Shooter,'Name')+' Dmg = '+floattostr(tmpDmg),Bad);
NDamageO[Victim] := Otrzymane;
if(GetPlayerStat(Victim,'Active')=true) then begin
UpdateNickname(GetPlayerStat(Victim,'name'),Victim);
if not NDamageO[Victim] = 0 then NDamageO[Victim] := 0;
end;
end;
end;
       Result:=Round(tmpDmg);
end;

[kicikici]

I would like to notice that it's a difference between

Code: [Select]

if not NDamageZ[Shooter] = 0 then NDamageZ[Shooter] := 0; and

Code: [Select]

if not (NDamageZ[Shooter] = 0) then NDamageZ[Shooter] := 0;.
I suggest replace

Code: [Select]

if not NDamageZ[Shooter] = 0 then NDamageZ[Shooter] := 0; this code:

Code: [Select]

NDamageZ[Shooter] := 0;

[dominikkk26]

WTF I would never expect that is just about the "(" ")".

Very Thanks!

[kicikici]

No problem